Skip to content

Fix invalid shorthand initialization diagnostic for tuple structs #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2020
Merged

Fix invalid shorthand initialization diagnostic for tuple structs #4857

merged 2 commits into from
Jun 12, 2020
+14 −1

Conversation

optimalstrategy
Copy link
Contributor

Initializing tuple structs explicitly, like in the example below, produces a "Shorthand struct initialization" diagnostic that leads to a compilation error when applied:

struct S(usize);

fn main() { 
    let s = S { 0: 0 };  // OK, but triggers the diagnostic
    // let s = S { 0 };  // Compilation error
}

This PR adds a check that the field name is not a literal.

jonas-schievink
jonas-schievink reviewed Jun 12, 2020
View reviewed changes
@jonas-schievink
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 12, 2020

Build succeeded:

@bors bors bot merged commit b56ad14 into rust-lang:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonas-schievink jonas-schievink jonas-schievink left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@optimalstrategy @jonas-schievink